Skip to content

Dynamic OCSP cache invalidation #13609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dynamic OCSP cache invalidation #13609

wants to merge 2 commits into from
+27 −8

Conversation

Vexali0n
Copy link

@Vexali0n Vexali0n commented Jul 11, 2025 •
edited
Loading

What this PR does / why we need it:

OpenResty Lua library supports for about a year new field for OCSP (next_update) which provides exact value retrieved directly from OCSP server until when the response is valid.
Here is the updated function in their repo: (https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/ocsp.lua#L126)

This feature is able to be used since those versions of libraries:
export LUA_NGX_VERSION=v0.10.27
export LUA_STREAM_NGX_VERSION=v0.0.15
export LUA_RESTY_CORE=v0.1.29

Currently main branch contains higher versions than this so this feature is available to be used:
export LUA_NGX_VERSION=v0.10.28
export LUA_STREAM_NGX_VERSION=v0.0.16
export LUA_RESTY_CORE=v0.1.31

Current solution caches OCSP response for fixed 3 days, this PR is able to set cache properly based on the real value provided by OCSP response, if OCSP response does not contain next_update field (its optional), we fallback to the original logic of fixed 3 days

This helps with better OCSP cache invalidation. Fixed 3 days no longer needed as the only option.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

How Has This Been Tested?

I received request to create proper cache invalidation for our nginx ingress controllers which are basically fork of your repo from which we are building the image of nginx controller. So tests were done in our own k8s clusters across 2 stages. Thanks to the log messages introduced in this PR, we were able to see what value has been used for cache invalidation directly in the nginx controller pods and it has matched with the OCSP response provided from OCSP server and hence we got much better cache invalidation.

K8s cluster 1.31.9
Nginx controller image built from your repo + changes introduced in this PR

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

Please, point out any issue you see with this PR. It is first time I am trying to merge code changes into your repo.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 11, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify Netlify
Copy link

netlify bot commented Jul 11, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 1d4c6d5
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-ingress-nginx/deploys/6870d49870f3ee00087fef4b

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vexali0n
Once this PR has been reviewed and has the lgtm label, please assign strongjz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the area/lua Issues or PRs related to lua code label Jul 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from strongjz July 11, 2025 08:45
@k8s-ci-robot
Copy link
Contributor

Welcome @Vexali0n!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority labels Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Vexali0n. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongjz strongjz Awaiting requested review from strongjz

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees
No one assigned
Labels
area/lua Issues or PRs related to lua code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vexali0n @k8s-ci-robot